Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart HTTP transport protocol handling #952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alixinne
Copy link

@alixinne alixinne commented Apr 5, 2023

This fixes the smart HTTP transport implementation receive pack service to send requests to /git-receive-pack instead of /info/Refs?service=git-upload-pack.

This issue seems to stem from a bad copy-paste, because this was the only difference when comparing the traces of a git push done with git2go with the regular git client.

In case of a HTTPS push, it would before result in a HTTP 405 Method Not Allowed (at least on the Gitea instance I was testing it on), and it now works.

This fixes the smart HTTP transport implementation receive pack service to send requests to `/git-receive-pack` instead of `/info/Refs?service=git-upload-pack`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants